View now a stateful widget to prevent memory leeks

This commit is contained in:
Yegor Vialov 2018-10-07 09:45:04 +03:00
parent 284e7ba451
commit b7fb821abe
3 changed files with 51 additions and 17 deletions

View File

@ -171,6 +171,7 @@ class _EntityWidgetState extends State<EntityWidget> {
return _buildBadgeWidget(context);
} else {
TheLogger.log("Error", "Unknown entity widget type: ${widget.widgetType}");
return Container(width: 0.0, height: 0.0);
}
}

View File

@ -28,8 +28,8 @@ class HomeAssistant {
StreamSubscription _socketSubscription;
int messageExpirationTime = 50; //seconds
Duration fetchTimeout = Duration(seconds: 45);
Duration connectTimeout = Duration(seconds: 15);
Duration fetchTimeout = Duration(seconds: 30);
Duration connectTimeout = Duration(seconds: 10);
String get locationName => _instanceConfig["location_name"] ?? "";
int get viewsCount => _entities.viewList.length ?? 0;
@ -95,8 +95,10 @@ class HomeAssistant {
(message) => _handleMessage(_connectionCompleter, message),
cancelOnError: true,
onDone: () {
TheLogger.log("Debug","Socket stream closed. Disconnected.");
disconnect();
TheLogger.log("Debug","Disconnect detected. Reconnecting...");
disconnect().then((_) {
_connection();
});
},
onError: (e) {
TheLogger.log("Error","Socket stream Error: $e");
@ -129,7 +131,9 @@ class HomeAssistant {
_completeConnecting(error);
if (!_fetchCompleter.isCompleted) {
if (error != null) {
disconnect().then((_){
_fetchCompleter.completeError(error);
});
} else {
_fetchCompleter.complete();
}

View File

@ -49,7 +49,7 @@ class View {
}
class ViewWidget extends StatelessWidget {
class ViewWidget extends StatefulWidget {
final List<Entity> badges;
final Map<String, CardSkeleton> cards;
final String displayName;
@ -61,6 +61,28 @@ class ViewWidget extends StatelessWidget {
this.displayName
}) : super(key: key);
@override
State<StatefulWidget> createState() {
return ViewWidgetState();
}
}
class ViewWidgetState extends State<ViewWidget> {
StreamSubscription _refreshDataSubscription;
Completer _refreshCompleter;
@override
void initState() {
super.initState();
_refreshDataSubscription = eventBus.on<RefreshDataFinishedEvent>().listen((event) {
if ((_refreshCompleter != null) && (!_refreshCompleter.isCompleted)) {
_refreshCompleter.complete();
}
});
}
@override
Widget build(BuildContext context) {
return RefreshIndicator(
@ -76,18 +98,18 @@ class ViewWidget extends StatelessWidget {
List<Widget> _buildChildren(BuildContext context) {
List<Widget> result = [];
if (badges.isNotEmpty) {
if (widget.badges.isNotEmpty) {
result.insert(0,
Wrap(
alignment: WrapAlignment.center,
spacing: 10.0,
runSpacing: 1.0,
children: _buildBadges(context, badges),
children: _buildBadges(context, widget.badges),
)
);
}
cards.forEach((String id, CardSkeleton skeleton){
widget.cards.forEach((String id, CardSkeleton skeleton){
result.add(
HACard(
entities: skeleton.childEntities,
@ -108,15 +130,22 @@ class ViewWidget extends StatelessWidget {
}
Future _refreshData() {
Completer refreshCompleter = Completer();
if ((_refreshCompleter != null) && (!_refreshCompleter.isCompleted)) {
TheLogger.log("Debug","Previous data refresh is still in progress");
} else {
_refreshCompleter = Completer();
eventBus.fire(RefreshDataEvent());
eventBus.on<RefreshDataFinishedEvent>().listen((event) {
refreshCompleter.complete();
});
return refreshCompleter.future;
}
return _refreshCompleter.future;
}
@override
void dispose() {
_refreshDataSubscription.cancel();
super.dispose();
}
}
class CardSkeleton {