yehor/ha_client
Archived
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Error handling improvements

Browse Source
This commit is contained in:
Yegor Vialov
2020-05-01 16:24:13 +00:00
parent 7a0ce93cfd
commit 46ca1948e2
8 changed files with 24 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lib/managers/auth_manager.class.dart
View File

@ -31,7 +31,7 @@ class AuthManager {
eventBus.fire(StartAuthEvent(oauthUrl, false));
completer.complete(tempToken);
}).catchError((e) {
Logger.e("Error getting temp token: ${e.toString()}");
Logger.e("Error getting temp token: $e");
eventBus.fire(StartAuthEvent(oauthUrl, false));
completer.completeError(HACException("Error getting temp token"));
}).whenComplete(() => flutterWebviewPlugin.close());

8
lib/managers/connection_manager.class.dart
View File

@ -65,9 +65,9 @@ class ConnectionManager {
.encodeComponent(
'https://ha-client.app/service/auth_callback.html')}";
settingsLoaded = true;
} catch (e) {
} catch (e, stacktrace) {
completer.completeError(HACException("Error reading login details", actions: [HAErrorAction.tryAgain(type: HAErrorActionType.FULL_RELOAD), HAErrorAction.loginAgain()]));
Logger.e("Cannt read secure storage. Need to relogin.");
Logger.e("Error reading secure storage: $e", stacktrace: stacktrace);
stopInit = true;
}
}
@ -212,7 +212,7 @@ class ConnectionManager {
//Logger.d("[Received] <== Request id ${data['id']} was successful");
_messageResolver["${data["id"]}"]?.complete(data["result"]);
} else if (data["id"] != null) {
Logger.e("[Received] <== Error received on request id ${data['id']}: ${data['error']}");
Logger.e("[Received] <== Error received on request id ${data['id']}: ${data['error']}", skipCrashlytics: true);
_messageResolver["${data["id"]}"]?.completeError("${data["error"]["code"]}: ${data["error"]["message"]}");
}
_messageResolver.remove("${data["id"]}");
@ -243,7 +243,7 @@ class ConnectionManager {
}
void _handleSocketError(e, Completer connectionCompleter) {
Logger.e("Socket stream Error: $e");
Logger.e("Socket stream Error: $e", skipCrashlytics: true);
_disconnect().then((_) {
if (!connectionCompleter.isCompleted) {
isConnected = false;

6
lib/managers/mobile_app_integration_manager.class.dart
View File

@ -56,7 +56,7 @@ class MobileAppIntegrationManager {
});
}).catchError((e) {
completer.complete();
Logger.e("Error registering the app: ${e.toString()}");
Logger.e("Error registering the app: $e");
});
return completer.future;
} else {
@ -98,10 +98,10 @@ class MobileAppIntegrationManager {
completer.complete();
}).catchError((e) {
if (e is http.Response && e.statusCode == 410) {
Logger.e("MobileApp integration was removed");
Logger.e("MobileApp integration was removed", skipCrashlytics: true);
_askToRegisterApp();
} else {
Logger.e("Error updating app registration: ${e.toString()}");
Logger.e("Error updating app registration: $e");
eventBus.fire(ShowPopupDialogEvent(
title: "App integration is not working properly",
body: "Something wrong with HA Client integration on your Home Assistant server. Please report this issue.",